feat(app): display correct creation method for PD protocol exported i…

[jerader]

…n py

closes AUTH-1525

Overview

If a protocol was made in PD and downloaded in py, we want the creation method to reflect the PD schema version

Test Plan and Hands on Testing

Review the code and test uploading to the app. look at the protocol details's creation method. here is a protocol you can test with:

ot2AllModules.py.zip

Changelog

• add logic for reading the protocolDesigner metadata
• add test case

Risk assessment

low, shouldn't encounter this in prod

[ddcc4]

How does parseInt() work here? If the string is

"protocolDesigner": "8.4.3",

do you want this to return 8.0?

[jerader]

8.4.3 -> 8, then the toFixed() goes to 8.0. We want to display the schema version to match a PD protocol exported in json

[ddcc4]

Oh! That was what was mentioned on the call about the PD version being the schema version.

[codecov]

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (b428d0a) to head (54ed08b).
Report is 1 commits behind head on edge.

Files with missing lines	Patch %	Lines
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx	61.11%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             edge   #17724   +/-   ##
=======================================
  Coverage   62.47%   62.47%           
=======================================
  Files        2792     2792           
  Lines      215277   215289   +12     
  Branches    18414    18416    +2     
=======================================
+ Hits       134498   134511   +13     
+ Misses      80594    80593    -1     
  Partials      185      185           

Flag	Coverage Δ
app	46.31% <61.11%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx	71.61% <61.11%> (+0.65%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ddcc4]

Should we make this 8.12.34 to demonstrate that we extract it as 8.0 no matter what the minor version is?

[jerader]

good point, i'll do that