Skip to content

Commit

Permalink
fix(hepa-uv): remove hepa-uv simulators so they don't block CI. (#746)
Browse files Browse the repository at this point in the history
* add NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init) to PushTipPresenceNotification, and GetMotorUsageResponse so lint does not fail
  • Loading branch information
vegano1 authored Jan 23, 2024
1 parent edb3207 commit 083a816
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build-simulators.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
gantry-y,
gripper,
head,
hepa-uv,
pipettes-single,
pipettes-multi,
pipettes-96,
Expand Down
6 changes: 2 additions & 4 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@
"pipettes-single-simulator",
"pipettes-multi-simulator",
"pipettes-96-simulator",
"gripper-simulator",
"hepa-uv-simulator"
"gripper-simulator"
]
},
{
Expand All @@ -260,8 +259,7 @@
"pipettes-single-simulator",
"pipettes-multi-simulator",
"pipettes-96-simulator",
"gripper-simulator",
"hepa-uv-simulator"
"gripper-simulator"
]
}
]
Expand Down
2 changes: 2 additions & 0 deletions include/can/core/messages.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1235,6 +1235,7 @@ struct BindSensorOutputResponse

using TipStatusQueryRequest = Empty<MessageId::get_tip_status_request>;

// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
struct PushTipPresenceNotification
: BaseMessage<MessageId::tip_presence_notification> {
uint32_t message_index;
Expand Down Expand Up @@ -1474,6 +1475,7 @@ struct SetGripperErrorToleranceRequest

using GetMotorUsageRequest = Empty<MessageId::get_motor_usage_request>;

// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
struct GetMotorUsageResponse
: BaseMessage<MessageId::get_motor_usage_response> {
uint32_t message_index;
Expand Down

0 comments on commit 083a816

Please sign in to comment.