feat(hepa-uv): Add the initial project for the HEPA/UV module #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vegano1
commented
Jan 9, 2024
•
vegano1
commented
- Add the initial HEPA/UV project
- scheduler is running and the status LED is blinking
- add hepa-uv Nodeid in conjunction with this monorepo pr.
sfoster1
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Excellent start, but I think we need to go through and make sure there's no copy/paste artifacts remaining, especially hardware configuration stuff. Anything that's in here is a vector for surprising crashes, so it's best to remove all the stuff that we're not going to test in the first pass and reintroduce it later.
fix node_id for the bootloader change old hepa_filter name to hepa_uv
remove copy/paste fragments fix simulator and tests remove i2c/spi/eeprom related files
add hepaa_uv.yaml for ci
sfoster1
requested changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.