Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ret 1406 add hepa tachometer #748

Closed
wants to merge 22 commits into from
Closed

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Jan 26, 2024

Overview

The HEPA fan has a frequency generator that serves as a tachometer allowing us to read the rpm and determine if the fan is spinning. This pr adds the plumbing and exposes the tachometer rpm so the hepa task can use it.

Closes: RET-1406

Change log

  • Adds the timer for the HEPA_FG tachometer and puts it in input capture mode
  • Calculate the rpm based on the tachometer period which we get every 4 rising pulses.
  • Exposes the rpm to the hepa task so it can be used in the future

Review requests

  • I'm still playing around with the timer frequency, the rpm does not match that of the fan datasheet.
  • However, does everything else make sense?
  • I've set the hepa fan duty cycle to 10% while I test.

@vegano1 vegano1 requested a review from sfoster1 January 26, 2024 21:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acede48) 83.71% compared to head (5524091) 83.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         101      101           
  Lines        4028     4028           
=======================================
  Hits         3372     3372           
  Misses        656      656           

@vegano1 vegano1 closed this Feb 8, 2024
@vegano1 vegano1 deleted the RET-1406_add_hepa_tachometer branch March 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants