-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipettes): sync moves with pressure sensor reading #749
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 83.58% 83.28% -0.30%
==========================================
Files 101 101
Lines 4044 4063 +19
==========================================
+ Hits 3380 3384 +4
- Misses 664 679 +15 |
ca9b08b
to
5a833f1
Compare
…ert syncline (this is moved to python)
5a833f1
to
0073d39
Compare
7085b36
to
8bb65f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get a Ci task that builds in the new configuration too to make sure nobody accidentally breaks it, and maybe see if we can add a bit in the device info?
Overview
This branch allows us to start and stop the pressure sensor in sync with the execution of a pipette move group.
It seems pretty involved for what it does currently, but I did it this way because I think it will make it easier in the near future to build code for collecting and packaging large amounts of sensor data while the move is happening.
It also is pretty messy with#ifdef
directives at the moment, but it has potential to be used for any sensor and could be nice to have for testing in the future, so any suggestions about making that a bit cleaner are much appreciated.To compile with this feature built in use
cmake --preset cross -DUSE_PRESSURE_MOVE
and this will set the compiler defs required to enable this featureChangelog
PipetteMotorInterruptHandler
class, which should allow us to sendBindSensorOutputRequest
messages directly to the pressure sensor taskAddSensorMoveRequest
, which is almost the same as anAddLinearMoveRequest
, but includes a sensor id (we can also add a parameter forSensorType
if we want to generalize this further)AddSensorMoveRequest
messages