Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(motor-control): move enable motor motion controller task #773

Closed
wants to merge 1 commit into from
Closed

fix(motor-control): move enable motor motion controller task #773

wants to merge 1 commit into from

Conversation

ahiuchingau
Copy link
Contributor

This seems to have fixed the motor enable/ebake not disengaging issue now that we have call the enable motor on the task level...

sfoster1
sfoster1 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once tested, though I wonder if we should have a force argument or something since right now there's no way to enable the motor that avoids the enabled check

@ahiuchingau
Copy link
Contributor Author

This issue is fixed by other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahiuchingau @sfoster1