fix(motor-control): Revert motor driver chip errors #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 762d6d5.
|
oof |
pmoegenburg
added a commit
that referenced
this pull request
Jul 22, 2024
This reverts commit 30ff770.
ryanthecoder
added a commit
that referenced
this pull request
Oct 24, 2024
ryanthecoder
added a commit
that referenced
this pull request
Oct 24, 2024
ryanthecoder
added a commit
that referenced
this pull request
Oct 25, 2024
) * Revert "Revert "fix(motor-control): Revert motor driver chip errors (#777)" (#796)" This reverts commit 4169f60. * add the pin definitions and driver configs * add driver definitions * add the can messages * init the diag pin as input * implement the pin polling paradime * return errors if trying to move while there is a motor driver error * fix struct init * fix some funtion declerations * hookup reading the status register * format * re-add timeout increase * brushed motor isn't hooked up to diag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in here is stall/collision detection errors and/or pipette firmware crashes in release testing