Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sensors): send the pressure sensor response with the baseline applied #783

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

ryanthecoder
Copy link
Contributor

Right now we send the raw sensor value instead of the corrected one, it will be better for lld development and just in general to get the corrected pressure data instead

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (34c52a3) to head (653afd1).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   83.28%   83.29%           
=======================================
  Files         101      101           
  Lines        4063     4065    +2     
=======================================
+ Hits         3384     3386    +2     
  Misses        679      679           

see 3 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cool

@ryanthecoder ryanthecoder merged commit 83f8f09 into main Jun 4, 2024
36 of 37 checks passed
ryanthecoder added a commit that referenced this pull request Jul 18, 2024
…lied (#783)

* send the pressure sensor response with the baseline applied

* aww dang missed a ;

* format

* keep signedness

* calculate the baseline correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants