feat(sensors): Self baselining during sensor moves #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th setting the sync line this way, it was turning off before the head node could detect it and stop
sfoster1
requested changes
Jun 24, 2024
| @@ -290,10 +293,21 @@ class MMR920 { | |||
| } | |||
|
|
|||
| void send_accumulated_sensor_data(uint32_t message_index) { | |||
|
|
||
| sensor_buffer_log(response_pressure); | ||
|
|
||
| if (sensor_buffer_index == 10 && !crossed_buffer_index) { |
There was a problem hiding this comment.
this 10 is setting the baselining window size, right? let's drop that in a define or a constexpr or something
|
|
||
| if (sensor_buffer_index == 10 && !crossed_buffer_index) { | ||
|
|
||
| current_pressure_baseline_pa = |
There was a problem hiding this comment.
why are we incrementing instead of setting this? won't this make it run away? also we could put 10*current_pressure_baseline_pa in the init argument to accumulate if we do want the accumulation
There was a problem hiding this comment.
I'll add a comment that explains why this won't run away
There was a problem hiding this comment.
re-worked it to make it more clear
ryanthecoder
force-pushed
the
EXEC-515-self-baselining
branch
from
0901b67 to
7a26107
Compare
ryanthecoder
force-pushed
the
EXEC-515-self-baselining
branch
from
50e5b5f to
ecd943b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 83.28% 82.62% -0.67%
==========================================
Files 101 102 +1
Lines 4063 4133 +70
==========================================
+ Hits 3384 3415 +31
- Misses 679 718 +39 |
sfoster1
approved these changes
Jun 26, 2024
ryanthecoder
added a commit
that referenced
this pull request
Jul 18, 2024
* Use logic or instead of hardcoded enums * when filling the bufffer auto baseline after the first 10 * the new method that lets us increase senstivity uncovered an issue with setting the sync line this way, it was turning off before the head node could detect it and stop * few tweaks to the way this works * only compute the first 10 elements to self-baselien * don't immediatly turn of the recording when move completes * save response pressure * fix the pressure leveling * rebase fixups * fix the hardware delay hack and get rid of another instance of it * send ack after sending buffer * fixes to the circular buffer * don't need this and can cause the process to choke * send the can messages faster * format * make the moving baseline log clearer * use the real world sensor speed * change auto baseline slightly to ignore the first N samples * add a new sensor sync value * don't trigger before autobaseline is finished * add new binding type for sensors and use the auto-baselineing during sensor moves * forgot to change an old reference * format lint * preserve old behavior * reduce the complexity in the handle function to satisfy lint * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We baseline the sensor reading during moves so that we can compensate better for different tips having a different baseline pressure differential when the plunger is moving