Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sensors): Enable dual sensor logic for 8/96 channel #789

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

ryanthecoder
Copy link
Contributor

Hardware testing wants the ability to do all of the following logic commands for LLD on the 8/96:
A only
B only
A or B
A and B

This lets the python side decide which of these to use.

@ryanthecoder ryanthecoder force-pushed the EXEC-586-dual-sensor-triggers branch from 861c573 to 6f061b8 Compare July 1, 2024 17:18
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ryanthecoder ryanthecoder force-pushed the EXEC-586-dual-sensor-triggers branch from 6f061b8 to 37f0d66 Compare July 1, 2024 18:41
@ryanthecoder ryanthecoder merged commit e8db5a4 into main Jul 1, 2024
38 of 39 checks passed
ryanthecoder added a commit that referenced this pull request Jul 18, 2024
* first pass idea

* move implementation to interface and add tests

* use new methods

* format lint

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants