Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix how the batch message is seralized on the firmware #815

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions include/can/core/messages.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1002,9 +1002,16 @@ struct BatchReadFromSensorResponse
bit_utils::int_to_bytes(static_cast<uint8_t>(sensor), iter, limit);
iter = bit_utils::int_to_bytes(static_cast<uint8_t>(sensor_id), iter,
limit);
iter = bit_utils::int_to_bytes(static_cast<uint8_t>(data_length), iter,
limit);
for (auto i = 0; i < data_length; i++) {
iter = bit_utils::int_to_bytes(sensor_data.at(i), iter, limit);
}
// Since python expects statically sized messages to unpack, pad the end
// with 0's
for (auto i = data_length; i < BATCH_SENSOR_MAX_LEN; i++) {
iter = bit_utils::int_to_bytes(int32_t(0), iter, limit);
}
return iter - body;
}
auto operator==(const BatchReadFromSensorResponse& other) const
Expand Down
Loading