Align the zombie NAT detection window with the 60-day fix criterion - #173
Merged
Conversation
The Athena/CUR query screened only the last full month while Fix step 1 required confirming < 5 GB/month over 60 days - an internal inconsistency flagged by the 2026-08-20 coverage probe. The query now spans the last two full months, expresses traffic as gb_per_month (monthly average, so the < 5 GB/month threshold reads unchanged), renames cost_month to cost_period, and Fix step 1 points back at the query's window instead of implying a second wider query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes an internal inconsistency in
skills/cloud-finops/playbooks/aws-zombie-nat-gateway.md, surfaced by the 2026-08-20 coverage probe: the Detection section's Athena/CUR query filtered to the last full month only, while Fix step 1 required confirming < 5 GB/month over a 60-day window ("one month can be misleading - some workloads run quarterly"). An agent walking a user through the playbook hits a query that cannot satisfy the fix criterion it feeds.How
interval '1' monthtointerval '2' month(still bounded at the start of the current month, so it covers the last two full months, roughly 60 days).gb_per_month(total over the window divided by 2, a monthly average), so the< 5 GB/monththreshold in the HAVING clause and the CloudWatch symptom keep identical semantics.cost_monthis renamedcost_periodto match the wider window.The
COALESCENULL-traffic guard from #166 is preserved (both SELECT and HAVING).Scope
Content PR: no version bumps, no frontmatter changes (so
playbook-coverage.mdis unaffected), structure / British spelling / footer intact. The 14-day quick-screen variant of this query inreferences/finops-waste-detection-playbooks.mdis a deliberately different first-pass screen and is untouched (a separate defect there - the NULL-blind SUM that #166 fixed in the playbooks - has been flagged as its own follow-up task).