Skip to content

Support symbol and asm data #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrytonLee merged 4 commits into from
Sep 23, 2025
Merged

Support symbol and asm data #39

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b2d2e7
feat: add symbol data
saying121 Sep 15, 2025
390e91f
feat: add task type
saying121 Sep 16, 2025
df0abdc
feat: asm task
saying121 Sep 17, 2025
5735852
feat: upload elf file
saying121 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions proto/psh.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ message Task {
oneof task_type {
WasmTask wasm = 3;
ProfilingTask profiling = 4;
DisasmTask disasm = 5;
}

message DisasmTask {
Symbol sym = 1;
}

message WasmTask {
Expand Down Expand Up @@ -85,6 +90,7 @@ message ExportDataReq {
LineProtocolData line_protocol = 2;
PerfDataProto perf_data = 3;
ElfSymbol symbol = 4;
Insns insns = 5;
}
}

Expand All @@ -110,3 +116,13 @@ message Symbol {
uint64 address = 3;
uint64 size = 4;
}

message Insns {
Copy link
Member

@BrytonLee BrytonLee Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可以在罗霄这端来做，不需要在PSH上解析。PSH可以直接把二进制文件传回给罗霄，罗霄通过build id进行索引。

Copy link
Contributor Author

@saying121 saying121 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把二进制传回的话，elfsymbol也可以在罗霄解析了，只需要传回文件跟build_id再加一些任务信息

Copy link
Member

@BrytonLee BrytonLee Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对，build_id每次都传回来，二进制文件按需传回，如果build_id 对应的二进制文件已经缓存了，就不需要再传送了。

repeated Instruction insns = 1;

message Instruction {
uint64 addr = 1;
optional string mnemonic = 2;
optional string op = 3;
}
}
Loading