Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arg uniqueness #93

Closed

Conversation

jubeaz
Copy link
Contributor

@jubeaz jubeaz commented May 25, 2024

Hello,

Here is a PR to manage argument uniqueness inside a command.

This is base on the issue that I've opened here #90

If accepted and merged I'll work on the concept of option [-debug] [-d <domain_fqdn] ...

Not that the logic of value computation has changed.

if inside a command there are <arg|value> the first one will be assigned to all the <arg> inside the command

after I will process the value based on gvars and cheat.variables, so this might again change the value of an arg

Anyway as I explained it in my issue for me having the same <arg> inside a command but wanting to have different value for them is an error

@jubeaz
Copy link
Contributor Author

jubeaz commented May 25, 2024

Hello,

same problem has in the previous PR
2024-05-25_17-37

@v1k1ngfr
Copy link
Collaborator

v1k1ngfr commented Aug 5, 2024

Hello @jubeaz,

We will keep arsenal as simple as possible with limited options. Maybe your PR can be useful for someone who have same expectations.

Thanks

@Guilhem7
Copy link
Collaborator

Thanks

@Guilhem7 Guilhem7 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants