-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pa11y-ci from 2.42.0 to 3.0.1 #938
Conversation
26eb3e7
to
f737a30
Compare
d31ced4
to
d53f89a
Compare
d53f89a
to
111f9ae
Compare
The same behavior than macOS is observed with Windows at Orange (less results than with Ubuntu). |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
For future selves. As a reminder. Rendering of pa11y tests locally when everything's OKRendering of pa11y tests locally with errors(for example if we remove a rule that hides some use cases) While runningAt the endRendering of pa11y-ci tests via GitHub actions with errorsWhile runningAt the endAnd in "Summary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok on my side
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Good job @louismaximepiton 💪 |
With this new version of pa11y-ci, the
axe-core
version has been bumped from 3.5.6 to 4.3.5 as well.It means that there are new errors (more than 400 😱) tracked by aXe (via pa11y) on Boosted.
It is needed to:
hiddenElements
configurationDeployed version of Boosted: https://deploy-preview-938--boosted.netlify.app/
Pa11y HTML report:
Example with the first new error
URL: http://localhost:9001/docs/5.1/getting-started/accessibility/
• Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)
(html > body > div:nth-child(6) > main > div:nth-child(3) > p:nth-child(3) > a:nth-child(1))
<abbr title="Web Content Access...
✘ 0/1 URLs passed
It is confirmed by the Firefox browser extension:
Reviewers
Checkout this
main-jd-bump-pa11y-ci
branch.Run
npm i
.Run
npm run start
in one console.Run
npm run docs-pa11y
in another console once the start is done.