Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graceful shutdown of workers threads in --test #3321

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix graceful shutdown of workers threads in --test #3321

merged 2 commits into from
Oct 25, 2024

Conversation

jcamiel
Copy link
Collaborator

@jcamiel jcamiel commented Oct 22, 2024

No description provided.

@jcamiel jcamiel linked an issue Oct 22, 2024 that may be closed by this pull request
Memory corruption when running the Hurl CLI with --test mode #3297
Closed
@jcamiel jcamiel changed the title Fix graceful shutdown of workers threads in --test. Fix graceful shutdown of workers threads in --test Oct 22, 2024
@jcamiel jcamiel force-pushed the 3297-memory-corruption-when-running-the-hurl-cli-with---test-mode branch 3 times, most recently from b984cd4 to e59c3b9 Compare October 25, 2024 06:08
@jcamiel jcamiel marked this pull request as ready for review October 25, 2024 17:43
@jcamiel
Copy link
Collaborator Author

jcamiel commented Oct 25, 2024

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, Orange-OpenSource/hurl/3297-memory-corruption-when-running-the-hurl-cli-with---test-mode now embeds these commits:

  • 6d7371b We use GitHub GraphQL API to get issues and PR referenced from issues.
  • 244177d Categorise options in --help
  • 79eca83 Update actions
  • d5f1b3e Remove the crate float-cmp.
  • 1a4c949 Update crates

@hurl-bot
Copy link
Collaborator

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the 3297-memory-corruption-when-running-the-hurl-cli-with---test-mode branch from e59c3b9 to f1a35a0 Compare October 25, 2024 17:44
@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/3297-memory-corruption-when-running-the-hurl-cli-with---test-mode branch into Orange-OpenSource/hurl/master branch:

  • f1a35a0 Remove unnessecary Shutdown message.
  • e8e5f2f Fix graceful shutdown of workers threads in --test.

@hurl-bot hurl-bot closed this Oct 25, 2024
@hurl-bot hurl-bot merged commit f1a35a0 into master Oct 25, 2024
23 checks passed
@hurl-bot hurl-bot deleted the 3297-memory-corruption-when-running-the-hurl-cli-with---test-mode branch October 25, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory corruption when running the Hurl CLI with --test mode
2 participants
@jcamiel @hurl-bot