feat: add color tokens in the demo app #158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of TokenProperty
Factorize token properties illustrations
🟢 Netlify deploy for commit 8efbd48 succeededDeploy preview: https://671bec779dee50bf73ea51d3--ouds-android.netlify.app |
paulinea
force-pushed
the
121-add-color-tokens-in-the-demo-app
branch
from
f459074
to
089e844
Compare
paulinea
force-pushed
the
121-add-color-tokens-in-the-demo-app
branch
from
089e844
to
63b6900
Compare
paulinea
force-pushed
the
121-add-color-tokens-in-the-demo-app
branch
from
70d2941
to
8efbd48
Compare
| @@ -160,6 +161,8 @@ private fun TokenIllustration(tokenProperty: TokenProperty, token: Token<Any>) = | |||
| is TokenProperty.BorderWidth -> BorderIllustrationBox(width = token.value as Dp) | |||
| is TokenProperty.BorderRadius -> BorderIllustrationBox(shape = RoundedCornerShape(token.value as Dp)) | |||
| is TokenProperty.BorderStyle -> BorderIllustrationBox(style = token.value as OudsBorderStyle) | |||
| is TokenProperty.ColorAction, TokenProperty.ColorAlways, TokenProperty.ColorBackground, TokenProperty.ColorBorder, TokenProperty.ColorBrand, TokenProperty.ColorContent, | |||
| TokenProperty.ColorElevation, TokenProperty.ColorGradient, TokenProperty.ColorDecorative -> IllustrationBox(backgroundColor = token.value as Color) | |||
There was a problem hiding this comment.
As described in Figma, we should add a black border when color is white in light mode, and a white border when color is black in dark mode.
| tokens = { OudsColorKeyToken.Gradient.entries.map { Token(it.name, it.value) } } | ||
| ) | ||
|
|
||
| data object ColorDecorative : TokenProperty( |
There was a problem hiding this comment.
Global colors are missing. I know it only contains the transparent color, but should we add it anyway?
| @@ -0,0 +1,10 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Copyright is missing and file should be added in NOTICE.txt (#168 will be our savior 🙏)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.