#6193: IHtmlFilter and TokenFilter improvements and bugfixes #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset unifies the two separate TokenFilter implementations (one for BodyPart, TextField, etc and another one for certain elements such as Html). It also fixes a bug with the TokenFilter when executing for HtmlWidget, where the wrong content item is being recorded by the handler (the original implementation). Thirdly, it removes awkward code repetition by moving filter execution into a dedicated HtmlFilterRunner service.
|
This also includes @jtkech 's work on fixing an encoding issue and execution order of the TokenFilter. |
| using Orchard.Core.Feeds; | ||
| using Orchard.Tags.Services; | ||
| using Orchard.Localization; | ||
| using System.Web.Routing; | ||
| using Orchard.Environment.Extensions; | ||
|
|
||
| namespace Orchard.Tags.Feeds { | ||
| namespace Orchard.Tags.Feeds | ||
| { |
|
Minus the comments it looks good. |
|
Does this one only waiting for a name and a curly brace rule correction? Best. |
BenedekFarkas
approved these changes
Apr 9, 2024
|
@sebastienros tested, good to go! |
BenedekFarkas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset unifies the two separate TokenFilter implementations (one for BodyPart, TextField, etc and another one for certain elements such as Html).
It also fixes a bug with the TokenFilter when executing for HtmlWidget, where the wrong content item is being recorded by the handler (the original implementation).
Thirdly, it removes awkward code repetition by moving filter execution into a dedicated HtmlFilterRunner service.
Fixes #6193