Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8012: Add Excel Export functionality to DynamicForms #8016

Merged
merged 5 commits into from
Apr 16, 2024
Merged

8012: Add Excel Export functionality to DynamicForms #8016

merged 5 commits into from
Apr 16, 2024

Conversation

TFleury
Copy link
Contributor

@TFleury TFleury commented Apr 6, 2018

closes #8012

@BenedekFarkas BenedekFarkas changed the title [feature] Add Excel Export functionality to DynamicForms. 8012: Add Excel Export functionality to DynamicForms Apr 10, 2024
@BenedekFarkas BenedekFarkas linked an issue Apr 10, 2024 that may be closed by this pull request
Add Excel Export functionality to DynamicForms #8012
Closed
@BenedekFarkas
Copy link
Member

I see that Maintainers are allowed to edit this pull request., but I can't push to the PR's branch, so I might create another PR from our fork with the same code. Anyway, I resolved the merge conflict and made small adjustments, otherwise this works great!

@sebastienros
Copy link
Member

@TFleury can you add @BenedekFarkas as a contributor to https://github.com/Codinlab/Orchard/tree/DynamicFormsExport or make this repository accept contributions for PRs? He'd like to fix and merge this PR. Thanks.

@TFleury
Copy link
Contributor Author

TFleury commented Apr 11, 2024

Done 👍

@BenedekFarkas
Copy link
Member

Thanks @TFleury, I've just pushed my changes!

@BenedekFarkas BenedekFarkas merged commit 04e9c73 into OrchardCMS:1.10.x Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenedekFarkas BenedekFarkas BenedekFarkas approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Excel Export functionality to DynamicForms
3 participants
@TFleury @BenedekFarkas @sebastienros