Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8686: Fixing build and tests on dev #8695

Merged
merged 71 commits into from
Mar 8, 2024
Merged

8686: Fixing build and tests on dev #8695

merged 71 commits into from
Mar 8, 2024

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented May 26, 2023

Fixes #8686

…ests broke in a3e9bef (issue #6802, PR #6919)

I should review PRs more carefully!
… (latest) to get rid of old System.Http.Net dependency
…rd.Web's web.config closer

so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
…o pin the correct version number (experimental)"

This reverts commit 087f284.
…to 4.1.0 (latest) to get rid of old System.Http.Net dependency"

This reverts commit be2ba86.
…/Hosting/Simple.Web/Web.config

since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
…test's usage of "I should not see" and correcting the parameters too

because unlike "I should see", this is not a regex match, just contains
…test's flakyness due to timing

because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
@BenedekFarkas BenedekFarkas changed the base branch from dev to issue/8684 May 26, 2023 13:47
@BenedekFarkas BenedekFarkas changed the title 8686: Fixing tests on dev 8686: Fixing build and tests on dev May 26, 2023
@BenedekFarkas BenedekFarkas self-assigned this May 26, 2023
# Conflicts:
#	.github/workflows/compile.yml
#	src/Orchard.Specs/Hosting/Orchard.Web/Web.config
#	src/Orchard.Web/Modules/Orchard.JobsQueue/Tests/Orchard.Messaging.Tests.csproj
@BenedekFarkas BenedekFarkas changed the base branch from issue/8684 to dev March 7, 2024 18:43
@BenedekFarkas BenedekFarkas marked this pull request as ready for review March 8, 2024 10:07
…tRandomly to decrease failure chance due to randomness
@BenedekFarkas BenedekFarkas merged commit 54ab14b into dev Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing build and tests on 1.10.x and dev
2 participants