Prevent TermsFilter from having to deal with empty strings #8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter them out before parsing them to int in form, convert taxonomies to OptionGroups rather than options with no value
sebastienros
reviewed
Nov 2, 2023
src/Orchard.Web/Modules/Orchard.Taxonomies/Projections/TermsFilter.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Nov 2, 2023
…lter.cs Co-authored-by: Sébastien Ros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed there was a chance for the TermsFilter to throw an exception, locking backoffice users from being able to edit the filter and use it. This happened in some cases when the user would select the taxonomy rather than a term, because the value for the taxonomy is an empty string: that could result in the filter attempting to parse empty strings to integers.
So: