Skip to content

Fix URL string when fetching homebrew content#638

Merged
datdamnzotz merged 1 commit intoOrcpub:developfrom
Jyers:develop
Jan 23, 2026
Merged

Fix URL string when fetching homebrew content#638
datdamnzotz merged 1 commit intoOrcpub:developfrom
Jyers:develop

Conversation

@Jyers
Copy link

@Jyers Jyers commented Jan 12, 2026

Description:

Small change to account for the fact that window.location.protocol always contains a colon, ie "https:" not "https".
This produced an error in fetching "homebrew.orcbrew" as the URL was malformed.
Remove the colon fixes this. This is the case for all browsers and systems.

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself bug Something isn't working labels Jan 13, 2026
@github-project-automation github-project-automation bot moved this to In progress in Orcpub Jan 13, 2026
@datdamnzotz datdamnzotz added this to the 2.5.0.29 milestone Jan 13, 2026
@datdamnzotz
Copy link

Fixes #639

@codeGlaze codeGlaze self-requested a review January 14, 2026 09:17
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Orcpub Jan 23, 2026
@datdamnzotz datdamnzotz merged commit e2131cf into Orcpub:develop Jan 23, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Orcpub Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/application Task related to orcpub application itself bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants