Skip to content

fix: Implement URL sanitization for DEX and website links #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odaysec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Implement URL sanitization for DEX and website links #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions app/app/components/DexCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,34 @@ interface DexCardProps {
timePeriod?: TimePeriod;
}

const sanitizeHref = (rawUrl: string | null | undefined): string => {
if (!rawUrl) return "#";

try {
let url: URL;

// Try parsing as absolute URL first
try {
url = new URL(rawUrl);
} catch {
// Fallback: treat as relative URL in browser environments
if (typeof window === "undefined") {
return "#";
}
url = new URL(rawUrl, window.location.origin);
}

const allowedProtocols = new Set(["http:", "https:"]);
if (!allowedProtocols.has(url.protocol)) {
return "#";
}

return url.toString();
} catch {
return "#";
}
};

const formatVolume = (num: number) => {
if (num >= 1e9) return `${(num / 1e9).toFixed(2)}B`;
if (num >= 1e6) return `${(num / 1e6).toFixed(2)}M`;
Expand Down Expand Up @@ -172,7 +200,7 @@ export default function DexCard({ broker, rank, timePeriod }: DexCardProps) {
<div className="flex gap-2">
{/* DEX Link CTA Button */}
<a
href={broker.dexUrl || "#"}
href={sanitizeHref(broker.dexUrl)}
target="_blank"
rel="noopener noreferrer"
onClick={e => e.stopPropagation()}
Expand All @@ -185,7 +213,7 @@ export default function DexCard({ broker, rank, timePeriod }: DexCardProps) {
{/* Website Link CTA Button */}
{broker.websiteUrl && (
<a
href={broker.websiteUrl}
href={sanitizeHref(broker.websiteUrl)}
target="_blank"
rel="noopener noreferrer"
onClick={e => e.stopPropagation()}
Expand Down