ON-467: Initial Marketplace Structure #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
karacurt
commented
Sep 14, 2023
•
karacurt
commented
- The Marketplace contract is upgradable by the Orium multisig.
- The Marketplace contract is pausable by the Orium multisig.
- Marketplace fees are 2.5% by default, but the Orium multisig must be able to set a different value per NFT collection.
- Creators Earnings is 0% by default, but the Orium multisig can set the creator of an NFT collection, and the creator can modify the Creators Earnings.
- The Marketplace has a maximum deadline parameter of 3 months, which should be configurable by the Orium multi-sig.
Co-authored-by: Ernani São Thiago <[email protected]>
ernanirst
requested changes
Sep 14, 2023
ernanirst
requested changes
Sep 14, 2023
Co-authored-by: Ernani São Thiago <[email protected]>
Co-authored-by: Ernani São Thiago <[email protected]>
ernanirst
requested changes
Sep 15, 2023
contracts/OriumMarketplace.sol
Outdated
| * @param _tokenAddress The address of the collection. | ||
| * @param _feeInfo The fee info. Contains the fee percentage in wei and if the fee is custom. | ||
| */ | ||
| function setMarketplaceFeeForCollection(address _tokenAddress, FeeInfo calldata _feeInfo) external onlyOwner { |
There was a problem hiding this comment.
Don't use struct ti facilitate on oppenzeppelin
ernanirst
requested changes
Sep 15, 2023
contracts/OriumMarketplace.sol
Outdated
| bool isCustomFee; | ||
| } | ||
|
|
||
| event CollectionFeeSet(address indexed tokenAddress, uint256 feePercentageInWei, bool isCustomFee); |
There was a problem hiding this comment.
Suggested change
| event CollectionFeeSet(address indexed tokenAddress, uint256 feePercentageInWei, bool isCustomFee); | |
| event MarketplaceFeeSet(address indexed tokenAddress, uint256 feePercentageInWei, bool isCustomFee); |
Co-authored-by: Ernani São Thiago <[email protected]>
ernanirst
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.