Merge pull request #244 from fr33ky/master

Add --no-check-certificate to wget call
Oteemo · Feb 2, 2021 · 3db358c · 3db358c
2 parents be2d446 + 83e3960
commit 3db358c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/charts/sonarqube/Chart.yaml b/charts/sonarqube/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 name: sonarqube
 description: SonarQube is an open sourced code quality scanning tool
-version: 9.2.7
+version: 9.3.0
 appVersion: 8.5.1-community
 keywords:
   - coverage

diff --git a/charts/sonarqube/README.md b/charts/sonarqube/README.md
@@ -116,6 +116,7 @@ The following table lists the configurable parameters of the Sonarqube chart and
 | `plugins.image`                       | Image for plugins container                                                                                                 | ""                                               | 
 | `plugins.resources`                   | Resources for plugins container                                                                                             | ""                                               | 
 | `plugins.netrcCreds`                  | Name of the secret containing .netrc file to use creds when downloading plugins                                             | ""                                               | 
+| `plugins.noCheckCertificate`          | Flag to not check server's certificate when downloading plugins                                                             | `false`                                          |
 | `jvmOpts`                             | Values to add to SONARQUBE_WEB_JVM_OPTS                                                                                     | `""`                                             | 
 | `env`                                 | Environment variables to attach to the pods                                                                                 | `nil`                                            | 
 | `annotations`                         | Sonarqube Pod annotations                                                                                                   | `{}`                                             | 

diff --git a/charts/sonarqube/templates/install-plugins.yaml b/charts/sonarqube/templates/install-plugins.yaml
@@ -22,7 +22,7 @@ data:
       [ -e {{ .Values.sonarqubeFolder }}/extensions/downloads/* ] && rm {{ .Values.sonarqubeFolder }}/extensions/downloads/*
       {{ range $index, $val := .Values.plugins.install }}
       echo {{ $val | quote }} >> {{ $.Values.sonarqubeFolder }}/extensions/downloads/list{{ end }}
-      cat {{ .Values.sonarqubeFolder }}/extensions/downloads/list | xargs -n 1 -P 8 wget --directory-prefix {{ .Values.sonarqubeFolder }}/extensions/downloads --no-verbose
+      cat {{ .Values.sonarqubeFolder }}/extensions/downloads/list | xargs -n 1 -P 8 wget --directory-prefix {{ .Values.sonarqubeFolder }}/extensions/downloads --no-verbose {{- if .Values.plugins.noCheckCertificate }}--no-check-certificate{{- end }}
       rm {{ .Values.sonarqubeFolder }}/extensions/downloads/list
     {{- end }}
     {{- if .Values.plugins.lib }}

diff --git a/charts/sonarqube/values.yaml b/charts/sonarqube/values.yaml
@@ -162,6 +162,9 @@ plugins:
   # .netrc secret file with a key "netrc" to use basic auth while downloading plugins
   # netrcCreds: ""
 
+  # Set to true to not validate the server's certificate to download plugin
+  noCheckCertificate: false
+
 ## Values to add to SONARQUBE_WEB_JVM_OPTS
 ##
 # jvmOpts: "-Djava.net.preferIPv4Stack=true"