Skip to content

chore: biome precommit and action #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btav merged 6 commits into from
Apr 13, 2025
Merged

chore: biome precommit and action #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a38c7ae
chore: biome precommit and action
btav Apr 13, 2025
ef286ac
test
btav Apr 13, 2025
d2ff900
fixed lint issues
btav Apr 13, 2025
c489285
chore: remove redundant Biome lint step from workflow
btav Apr 13, 2025
0ccf978
chore: replace format check with lint step in workflow
btav Apr 13, 2025
d5d5f8a
chore: update biome configuration to ignore src/data directory
btav Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/biome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Biome Lint and Format

on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "22"

- name: Install dependencies
run: npm install

- name: Run Biome lint
run: npm run lint
1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npm run lint:fix
2 changes: 1 addition & 1 deletion biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"files": {
"ignoreUnknown": false,
"ignore": []
"ignore": ["src/data"]
},
"formatter": {
"enabled": true,
Expand Down
19 changes: 18 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@
"astro": "astro",
"data": "node scripts/fetchMeetupData.js",
"lint": "biome check src/*",
"lint:fix": "biome check --write src/*"
"lint:fix": "biome check --write src/*",
"prepare": "husky"
},
"dependencies": {
"astro": "^5.5.6"
},
"devDependencies": {
"@biomejs/biome": "1.9.4"
"@biomejs/biome": "1.9.4",
"husky": "^9.1.7"
}
}
3 changes: 1 addition & 2 deletions src/components/Navigation.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import logo from "../assets/forward.svg";
---

<header>
<nav>
<div class="logo">
<nav> <div class="logo">
<img src={logo.src} alt="ForwardJS Logo" width="32" loading="eager" />
<span>FORWARDJS</span>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Sponsors.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import SponsorLink from "./SponsorLink.astro";

import Fullscript from "../assets/fullscript.svg";
import Jetbrains from "../assets/jetbrains.svg";
import Owner from "../assets/owner.webp";
import Shopify from "../assets/shopify.svg";
import Spiria from "../assets/spiria.svg";
import TalentLab from "../assets/talentlab.webp";
import Owner from "../assets/owner.webp";

const sponsors = [
{
Expand Down
2 changes: 1 addition & 1 deletion src/data/pastEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,4 @@
"address": "360 Albert St suite 200 Ottawa ON ca"
}
}
]
]
2 changes: 1 addition & 1 deletion src/data/upcomingEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
"address": "151 O’Connor, Ottawa ON CA"
}
}
]
]
12 changes: 8 additions & 4 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
font-display: swap;
src: url(/fonts/libre-franklin-100-900-italic-vietnamese.woff2)
format("woff2");
unicode-range: U+0102-0103, U+0110-0111, U+0128-0129, U+0168-0169, U+01A0-01A1,
unicode-range:
U+0102-0103, U+0110-0111, U+0128-0129, U+0168-0169, U+01A0-01A1,
U+01AF-01B0, U+0300-0301, U+0303-0304, U+0308-0309, U+0323, U+0329,
U+1EA0-1EF9, U+20AB;
}
Expand All @@ -27,7 +28,8 @@
font-weight: 100 900;
font-display: swap;
src: url(/fonts/libre-franklin-100-900-italic-latin.woff2) format("woff2");
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA,
unicode-range:
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA,
U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}
Expand All @@ -39,7 +41,8 @@
font-display: swap;
src: url(/fonts/libre-franklin-100-900-normal-vietnamese.woff2)
format("woff2");
unicode-range: U+0102-0103, U+0110-0111, U+0128-0129, U+0168-0169, U+01A0-01A1,
unicode-range:
U+0102-0103, U+0110-0111, U+0128-0129, U+0168-0169, U+01A0-01A1,
U+01AF-01B0, U+0300-0301, U+0303-0304, U+0308-0309, U+0323, U+0329,
U+1EA0-1EF9, U+20AB;
}
Expand All @@ -60,7 +63,8 @@
font-weight: 100 900;
font-display: swap;
src: url(/fonts/libre-franklin-100-900-normal-latin.woff2) format("woff2");
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA,
unicode-range:
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA,
U+02DC, U+0304, U+0308, U+0329, U+2000-206F, U+2074, U+20AC, U+2122, U+2191,
U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}
Expand Down