Adding helm homework #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agneum
requested changes
Feb 27, 2024
| - Написать k8s манифесты для процессов приложения календаря (deployment, service, ingress) | ||
| - Написать helm chart для шаблонизации манифестов, создать values файл с дефолтными значениями | ||
|
|
||
| ### Критерии оценки |
There was a problem hiding this comment.
Думаю, что будет здорово, если сумма баллов в критерии оценки будет соответствовать остальным заданиям, т.е 10
| - Созданы yaml манифесты для deployment, service, ingress - 3 балла | ||
| - Есть liveness и readiness пробы - 1 балл | ||
| - Написан helm чарт, есть values файл - 2 балла | ||
| - Makefile заполнен и пайплайн зеленый - 1 балл |
There was a problem hiding this comment.
Каким образом пайплайн проверяет корректность задания?
There was a problem hiding this comment.
Кажется тут нужны изменения в нашем ci
| @@ -3,11 +3,13 @@ | |||
| - [Домашнее задание №13 «Внешние API от Календаря»](./docs/13_README.md) | |||
There was a problem hiding this comment.
Вероянтно, следует переименовать директорию и добавить 16
| @@ -0,0 +1,22 @@ | |||
| ## Домашнее задание №16 «Шаблонизация манифестов "Календаря"» | |||
There was a problem hiding this comment.
Предлагаю добавить ссылку на этот файл в README в корне репозитория, по аналогии с остальными заданиями
| - Makefile заполнен и пайплайн зеленый - 1 балл | ||
|
|
||
|
|
||
| #### Зачёт от 6 баллов |
There was a problem hiding this comment.
Есть ли подсказки для студентов и частые ошибки, на которые следует обратить внимание при выполнении задания?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.