fix(windows): stop the example auto-printing on every page load - #10
Merged
Merged
Conversation
onLoadStop fired a silent printCurrentPage on each navigation, so every run of the example popped the "Save Print Output As" dialog (or spooled to the default printer) - over whatever window happened to be focused. Printing stays fully covered by the example's explicit Print buttons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows example's
onLoadStopfires a silentprintCurrentPageon every navigation. Each run of the example therefore pops the system "Save Print Output As" dialog (or spools a page to the default printer), landing over whatever window happens to be focused. Besides being surprising, the browser-owned dialog sits over the webview area and contaminates any manual testing or input/hit-testing diagnostics run against the example (it skewed several measurements during the Otzaria/otzaria#882 investigation until spotted).Fix
Remove the auto-print from
onLoadStop. Printing remains fully exercised by the example's explicit Print (Silent) / Print (Dialog) buttons, which is also where a demo action belongs — behind user intent.🤖 Generated with Claude Code