Hatchmap and scattermap fixes #195
Conversation
…oved deepcopy operation which is already happening in calling utils.empty_dict()
…lling utils.empty_dict()
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
figanos/matplotlib/plot.py
Outdated
| levels=levels, | ||
| divergent=divergent, | ||
| ) | ||
|
|
||
| # matplotlib.pyplot.scatter treats "edgecolor" and "edgecolors" as aliases so we accept "edgecolor" and convert it |
There was a problem hiding this comment.
I wouldn't pop edgecolor and replace it to edgecolors since both of them work and if matplotlib ever made change to one we would have to fix it after. I also think edgecolors is more used to pass many colors as a list.
figanos/matplotlib/plot.py
Outdated
| "cmap": cmap, | ||
| "norm": norm, | ||
| "transform": transform, | ||
| "zorder": 8, | ||
| "marker": "o", | ||
| } | plot_kw_pop | ||
| "edgecolors": "none", |
There was a problem hiding this comment.
I would remove this line based on previous comment
| @@ -180,7 +180,7 @@ | |||
| "im = fg.hatchmap({'sup_305k': sup_305k, 'inf_300k': inf_300k},\n", | |||
| " plot_kw={\n", | |||
| " 'sup_305k': {\n", | |||
| " 'hatches': '*',\n", | |||
| " 'hatches': ['////'], # hatches must be passed as a list\n", | |||
There was a problem hiding this comment.
Maybe use can instead of must
figanos/matplotlib/plot.py
Outdated
| if extend: | ||
| fax.set_extent(extend) | ||
| if extent: | ||
| fax.set_extent(extent) | ||
|
|
There was a problem hiding this comment.
| if isinstance(plot_kw[k]["hatches"], list): | |
| hc = plot_kw[k]["hatches"][0] | |
| else: | |
| hv = plot_kw[k]["hatches"] | |
figanos/matplotlib/plot.py
Outdated
|
|
||
| pat_leg.append( | ||
| matplotlib.patches.Patch( | ||
| hatch=plot_kw[k]["hatches"], fill=False, label=k | ||
| hatch=plot_kw[k]["hatches"][0], fill=False, label=k |
There was a problem hiding this comment.
| hatch=plot_kw[k]["hatches"][0], fill=False, label=k | |
| hatch=hc, fill=False, label=k |
|
The Coveralls checks have been adjusted. These shouldn't fail unless coverage is dramatically impacted. |
Est-ce que avoir coverall c'est pertinent si on n'a pas de tests? comme c'est des figures, c'est difficile de tester ... |
# Conflicts: # CHANGELOG.rst # src/figanos/matplotlib/plot.py
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Some fixes and simplification of code:
hatchmap.scattermapcan use’edgecolor’and’egdecolors’interchangeably like `matplotlib.pyplot.scatter’deepcopyoperation inhatchmapandscattermapwhich is already called infiganos.matplotlib.utils.empyt_dict(). Consequently, helper variables are renamed (plot_kw_pop->plot_kwinscattermap;dc->plot_kwinhatchmap`.extendtoextentDoes this PR introduce a breaking change?
No
Other information: