-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More extract features for RDRS #182
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6406d6f
new features
juliettelavoie 7dac9a0
better hist
juliettelavoie b171429
Merge branch 'main' into fix-180
juliettelavoie 311b86a
Apply suggestions from code review
juliettelavoie bba4a17
put back the mask
juliettelavoie aa1b126
Merge remote-tracking branch 'origin/fix-180' into fix-180
juliettelavoie ecc318f
move subset to spatial
juliettelavoie 18962b6
add dataArray
juliettelavoie d43335a
replace inside of clisops_subset
juliettelavoie bbc4b8c
update history
juliettelavoie 343cdbc
update doc
juliettelavoie 621e3e3
add name update
juliettelavoie df2fd17
remove name update from extract
juliettelavoie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also accept a
DataArray
?I don't find the "bool" option very useful, but I see that #183 would complete this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure for DataArray.
I guess it is only useful for me now that I already have a mask that is in the catalogue.