-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interfaces and tests for nearest neighbors and embeddings #50
Conversation
gschoeni
commented
Dec 13, 2024
•
edited
Loading
edited
@jcelliott @EloyMartinez there are test parquet files in the Let me know if the APIs make sense and are intuitive to use or if we should iterate on them. Also we should do a python deep dive sometime this week with the team. |
@@ -20,6 +20,8 @@ dependencies = [ | |||
"requests", | |||
"toml", | |||
"tqdm", | |||
"torch", | |||
"tensorflow", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will make package managers try to install torch and tensorflow as dependencies for oxen. Is that what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debating, because they are used in our data loaders (that are undocumented) but are a heavy install. Maybe we do just keep them in the dev dependencies for now...
Worked for me, and I think the interface makes sense. Not really related to this PR, but I ran into that issue with the |