fixed aria labels for signin dropdown

OxfordRSE · May 8, 2024 · 0d4c0c4 · 0d4c0c4
1 parent 29e06ea
commit 0d4c0c4
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/components/Navbar.tsx b/components/Navbar.tsx
@@ -301,29 +301,21 @@ const Navbar: React.FC<Props> = ({
           </li>
         )}
 
-        <li>
+        <li aria-label={session ? session.user?.name || "Account details" : "Sign in"}>
           <Dropdown
             label={
               <span className="inline-flex items-center text-gray-700 hover:text-gray-900 dark:text-gray-400 dark:hover:text-white w-10 h-10">
                 {session ? (
                   <Avatar
                     role="img"
-                    aria-label={session.user?.name || "Account details"}
                     img={session.user?.image ? session.user?.image : undefined}
                     className="w-8 h-8"
                     size="sm"
                     rounded={true}
                     data-cy={`avatar-${session.user?.email}`}
                   />
                 ) : (
-                  <Avatar
-                    role="img"
-                    aria-label="Sign in"
-                    className="w-8 h-8"
-                    size="sm"
-                    rounded={true}
-                    data-cy={`avatar-not-signed-in`}
-                  />
+                  <Avatar role="img" className="w-8 h-8" size="sm" rounded={true} data-cy={`avatar-not-signed-in`} />
                 )}
               </span>
             }