New user comment table on event page #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d display user avatars
…s rather than putting the thread in the dom direct
…d display user avatars
…at breaks the aftereach in cypress
alasdairwilson
force-pushed
the
student-comments-table
branch
from
dab3409 to
cbe932c
Compare
martinjrobins
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
looks great @alasdairwilson :) I noticed that you used the flowbite Avatar rather than the mui one, is that my accident?
alasdairwilson
force-pushed
the
student-comments-table
branch
from
7bccb20 to
abc5a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to fix #269 and so took a pass at the whole table:
There are now 2 tables for resolved and unresolved comments, the unresolved starts off collapsed.
Because on old events there will be broken links (see #270) there will be threads that you cant link from, these are grouped into an automatically hidden section (No section found)
Comments are now grouped by the section they originated on (again collapsible) there are now links to the whole section and perhaps the most cool thing is that the thread itself can now be opened inside the event page and replied to/deleted/resolved. It is probable that you might get instant feedback on the deletion because I didn't do the instant mutation of the api call result since its a pain and this is buried well in the back of the site and probably will never be used.
There is a significant change to how commentthreads are added to the dom: they are now added by createportal which means the position of them can be changed at will rather than being embedded in the dom with the thread icon component.
The old one ^ is naff: