Skip to content

units.py - ampere #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alitaqiEngOx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

units.py - ampere #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/oxrse_unit_conv/units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
lb = pound

# ampere
ampere = Unit(name='ampere', abbr='A', si=ampere, to_si_fun=lambda n: n)
Copy link
Copy Markdown
Collaborator

@shahriartj shahriartj Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferably a small letter is better for the abbreviation!

Copy link
Copy Markdown
Collaborator

@shahriartj shahriartj Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test?


# kelvin

Expand Down