Black themes are not correctly toned down

[hknutsen]

Description

After upgrading to 4.0.0-dev3, I no longer get a pure-black background on the "Now playing" screen when the pure-black theme is enabled.

Library screen with pure-black theme enabled:

"Now playing" screen with pure-black theme enabled (background is not pure-black):

Library screen background color vs "Now playing" screen background color:

Evidence that pure-black theme ("Svart drakt" in Norwegian) is enabled:

Problem solved

No response

Other implementations

Other music players (Poweramp, Retro Music Player, Oto Music) enable a pure-black background on the "Now playing" screen when the pure-black theme (or their equivalent feature) is enabled.

Benefit

Improves visual consistency when pure-black theme is enabled.

Duplicates

• I have checked this feature request for duplicates.
• I have checked that this feature is not implemented in the lastest version.
• I have checked the Why Are These Features Missing? page.
• I agree to the Contribution Guidelines.

[Richard38907]

Same here, please re-add pure black player when "pure black" option is set to on.

[OxygenCobalt]

The new M3 guidelines require the use of these elevated colors, so the most I can do is tone them down. That requires me to regenerate most of my themes, I think. Will look into this, probably won't be 4.0.0.

[TempUser13]

Would you consider doing the M3 black theme and a non M3 black theme / adding something like a 0 contrast/depth option (removing the grey parts) because it is kinda misleading having the grey colors there which isn't an attack on you or your choice to do M3 but it will be a thing stopping people upgrading and getting all of the benefits of v4.

[OxygenCobalt]

Since this seems quite in demand, I'm reclassifying this was a regression and going to focus on adding it to a patch release.

[OxygenCobalt]

0 contrast/depth option (removing the grey parts)

I mean, I could make the sheet backgrounds use outlines. This might be the easiest way to do """black mode"""

[TempUser13]

Thank you for reclassifying this as a regression and looking to "fix" it.

[OxygenCobalt]

New toned down black theme: Auxio_Canary.zip @TempUser13 @hknutsen @Richard38907

This is the most I'm willing to tone it down, any further and it starts colliding against the dynamic color options I have.

[hknutsen]

Looks much better to me, @OxygenCobalt. Thanks! 🙌