feat: share songs in album order #1174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rijnder Wever <[email protected]>
Signed-off-by: Rijnder Wever <[email protected]>
|
Sorry for the force push, I didn't have GPG signing setup yet. |
|
Thanks for the contribution! Sorry for the delay. |
OxygenCobalt
requested changes
Sep 6, 2025
| fun Context.share(parent: MusicParent) { | ||
| if (parent is Album) { | ||
| // share songs in album order | ||
| val sorted = parent.songs.sortedWith(compareBy({ it.disc ?: 0 }, { it.track ?: 0 })) |
There was a problem hiding this comment.
I'd recommend taking a look at the Sort class rather than doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of changes
When sharing an album (and only when sharing an album), Auxio now shares the songs in album order.
The reasoning here is that if a user shares an album to an other app, such as a streaming app, the user probably wants that app to play/consume these tracks in album order. Before this change, the order appeared random on the end of the receiving app.
I've thought about adding sorting to other types of
MusicParent, but they all lack a natural ordening, IMO.Fixes the following issues
Somewhat related to #379. I've wanted to switch to Auxio for a long time (to go 100% FOSS), but I'm incredibly accustomed to casting stuff from my phone.
Then I realized that since Auxio can share collections of files to Kore (a Kodi remote app), and since Kore can in turn stream files over http to Kodi, you basically have rudimentary FOSS casting.
In my test, this whole chain works pretty great!
For the whole plan to go through, however, the Kore devs still need to approve a pull request (xbmc/Kore#1043).
Any additional information
Thanks for developing Auxio!
APK testing
app-debug.apk.zip
Due Diligence