Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oci provider deployment #12

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

omurilo
Copy link
Contributor

@omurilo omurilo commented Jan 22, 2024

Add a Oracle Cloud Infrastructure as provider to deployment terraguard

@Rapha-Borges
Copy link

I've created a pull request on your branch with some minor fixes. The details are as follows:

The declaration of the variable availability_domain with the number type enables the project to be used in accounts with limited resource availability. Free accounts have resource limitations based on availability domains (AD).

  • README.md
    [X] Modified the oci session authenticate command to use sudo in accordance with project requirements.
    [X] Added TF_VAR for region and availability domains, making it easier to apply in other regions.
    [X] Added instructions to run the sudo terraform -E command for the use of previously exported TF_VAR.

  • modules/.../variables.tf
    [X] Refactored for use with modules

  • variables.tf
    [X] Added the variable availability_domain and removed the default field in the region variable.
    [X] Refactored for use with modules

  • modules/instance/main.tf
    [X] Implementation of the availability_domain variable.

  • .gitignore
    [X] Added **/.terraform* to the .gitignore file.

@omurilo
Copy link
Contributor Author

omurilo commented Jan 25, 2024

I've created a pull request on your branch with some minor fixes. The details are as follows:

The declaration of the variable availability_domain with the number type enables the project to be used in accounts with limited resource availability. Free accounts have resource limitations based on availability domains (AD).

* README.md
  [X] Modified the `oci session authenticate` command to use sudo in accordance with project requirements.
  [X] Added `TF_VAR` for region and availability domains, making it easier to apply in other regions.
  [X] Added instructions to run the `sudo terraform -E` command for the use of previously exported `TF_VAR`.

* modules/.../variables.tf
  [X] Refactored for use with modules

* variables.tf
  [X] Added the variable `availability_domain` and removed the `default` field in the `region` variable.
  [X] Refactored for use with modules

* modules/instance/main.tf
  [X] Implementation of the `availability_domain` variable.

* .gitignore
  [X] Added `**/.terraform*` to the `.gitignore` file.

LGTM, only comment about availability var number

@Rapha-Borges
Copy link

Rapha-Borges commented Jan 25, 2024

LGTM, only comment about availability var number

Fixed!

Once you make the proposed changes, I believe it will be ready for the merge.

I successfully tested it on three different accounts.

@P0ssuidao P0ssuidao self-requested a review January 27, 2024 13:37
feat: update OCI provider configurations to use variables on modules
Copy link

@Rapha-Borges Rapha-Borges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! @P0ssuidao if the variable formats work for you, I believe you can proceed with the merge. Everything works fine, and looks great!

@omurilo
Copy link
Contributor Author

omurilo commented May 25, 2024

@P0ssuidao has any issue about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants