Various EFS Shell fixes #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ln command in EFS Shell operates the same as ln on Linux: it takes the existing file first and the new link second. But the argument names were swapped, making the argparse help text confusing.
When we have list permission for a directory but not read permission for a file within that directory, all metadata for that file except its name is zeroed out. Currently, this causes a crash looking up the "File type" string. Add a new entry to gracefully handle this case. Unknown files now look like this: +---------------------------------------------------------------------------------------------------------------------------+ + File type | Special flags | File rights | File name | File size | Modification | Creation + +---------------------------------------------------------------------------------------------------------------------------+ + Unknown | | --------- | 'mcfg' | 0 | 1969-12-31 19:00:00 | 1969-12-31 19:00:00 + +---------------------------------------------------------------------------------------------------------------------------+
When removing a symlink, we want to know about the link itself and not its target to select between unlink() and rmdir().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details. Please don't squash when merging, as each commit is independent.