Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run certain workflows when necessary #192

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

P403n1x87
Copy link
Owner

We add path filtering to some GitHub workflows so that they are triggered when necessary.

We add path filtering to some GitHub workflows so that they are
triggered when necessary.
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (76c0245) 68.04% compared to head (97d3413) 68.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #192      +/-   ##
==========================================
- Coverage   68.04%   68.00%   -0.05%     
==========================================
  Files          27       27              
  Lines        2485     2485              
  Branches      761      761              
==========================================
- Hits         1691     1690       -1     
- Misses        458      459       +1     
  Partials      336      336              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Austin Benchmarks

Running Austin benchmarks with Python 3.10.12

Benchmark Summary

Comparison of dev against 3.5.0.

The following scenarios show a statistically significant difference in performance between the two versions.

Sample Rate Saturation Error Rate Sampling Speed
Wall time [sampling interval: 1000] 🟡 🟡 🟡 🔴
CPU time [sampling interval: 10] 🟡 🟢 🟡 🟡
CPU time [sampling interval: 100] 🟢 🟡 🟡 🟡
CPU time [sampling interval: 1000] 🟡 🟡 🟡 🔴
RSA keygen [sampling interval: 10] 🟡 🟢 🔴 🟡
Full metrics [sampling interval: 1] 🟡 🟡 🟡 🟢
Full metrics [sampling interval: 10] 🟡 🟡 🟢 🟡
Multiprocess wall time [sampling interval: 100] 🟡 🟡 🟢 🟡

Benchmark Results

Wall time [sampling interval: 1]

Wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 122000 ± 3000 1 ± 0 5e-06 ± 4e-06 12.7 ± 0.5
3.5.0 123900 ± 900 1 ± 0 8e-06 ± 4e-06 12.5 ± 0.5
dev 123000 ± 4000 1 ± 0 9e-06 ± 5e-06 12.4 ± 0.5
Wall time [sampling interval: 10]

Wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 121000 ± 4000 0.544 ± 0.002 8e-06 ± 4e-06 12.7 ± 0.5
3.5.0 121000 ± 5000 0.543 ± 0.002 9e-06 ± 3e-06 12.6 ± 0.5
dev 121000 ± 4000 0.543 ± 0.002 7e-06 ± 3e-06 12.5 ± 0.5
Wall time [sampling interval: 100]

Wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 10800 ± 300 0.0006 ± 0.0001 1e-05 ± 2e-05 14.1 ± 0.6
3.5.0 10700 ± 200 0.0007 ± 0.0002 2e-05 ± 2e-05 14.4 ± 0.5
dev 10900 ± 400 0.00065 ± 0.0001 2e-05 ± 2e-05 14.2 ± 0.4
Wall time [sampling interval: 1000]

Wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 1860 ± 40 0.0 ± 0.0001 2e-05 ± 6e-05 17.4 ± 0.5
3.5.0 1860 ± 20 2e-05 ± 6e-05 2e-05 ± 6e-05 18 ± 1
dev 1860 ± 20 0.0001 ± 0.0002 2e-05 ± 6e-05 20 ± 2
CPU time [sampling interval: 1]

CPU time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 51000 ± 3000 1 ± 0 1.4e-05 ± 8e-06 23.2 ± 0.8
3.5.0 53000 ± 1000 1 ± 0 1.2e-05 ± 8e-06 22.5 ± 0.5
dev 52000 ± 4000 1 ± 0 1.6e-05 ± 6e-06 23 ± 1
CPU time [sampling interval: 10]

CPU time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 52000 ± 2000 0.9986 ± 0.0002 1.7e-05 ± 7e-06 22.6 ± 0.5
3.5.0 53000 ± 2000 0.9985 ± 0.0002 9e-06 ± 6e-06 22.6 ± 0.5
dev 52000 ± 2000 0.9983 ± 0.0001 1e-05 ± 7e-06 22.6 ± 0.5
CPU time [sampling interval: 100]

CPU time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 5420 ± 100 0.001 ± 0.0001 9e-05 ± 4e-05 23.4 ± 0.5
3.5.0 5340 ± 50 0.0012 ± 0.0004 5e-05 ± 7e-05 24 ± 1
dev 5460 ± 80 0.001 ± 0.0002 3e-05 ± 5e-05 23.9 ± 0.7
CPU time [sampling interval: 1000]

CPU time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 946 ± 2 0.0003 ± 0.0005 0.0001 ± 0.0002 32 ± 2
3.5.0 946 ± 4 0.0002 ± 0.0003 0 ± 0 31 ± 2
dev 945 ± 1 0.0006 ± 0.0006 0.0001 ± 0.0002 34 ± 3
RSA keygen [sampling interval: 1]

RSA keygen [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 38900 ± 800 1 ± 0 0.0003 ± 0.0003 25.0 ± 0.5
3.5.0 39000 ± 2000 1 ± 0 0.0005 ± 0.0007 24.9 ± 0.7
dev 40000 ± 1000 1 ± 0 0.0002 ± 0.0002 24.6 ± 0.8
RSA keygen [sampling interval: 10]

RSA keygen [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 40000 ± 1000 0.98 ± 0.01 0.0003 ± 0.0001 24.7 ± 0.7
3.5.0 40000 ± 1000 0.987 ± 0.009 0.0002 ± 0.0001 24.6 ± 0.7
dev 39400 ± 600 0.97 ± 0.02 0.0004 ± 0.0002 24.4 ± 0.5
RSA keygen [sampling interval: 100]

RSA keygen [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 6300 ± 20 0.003 ± 0.002 0.0006 ± 0.0005 28 ± 2
3.5.0 6310 ± 10 0.002 ± 0.002 0.0006 ± 0.0005 27 ± 2
dev 6280 ± 60 0.002 ± 0.003 0.001 ± 0.002 28 ± 2
RSA keygen [sampling interval: 1000]

RSA keygen [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 941 ± 2 0 ± 0 0.002 ± 0.002 36 ± 2
3.5.0 940 ± 3 0 ± 0 0.002 ± 0.003 36 ± 4
dev 941 ± 3 0 ± 0 0.002 ± 0.003 36 ± 3
Full metrics [sampling interval: 1]

Full metrics [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 49000 ± 3000 1 ± 0 2.7e-05 ± 9e-06 31 ± 2
3.5.0 51800 ± 400 1 ± 0 1.7e-05 ± 5e-06 29.8 ± 0.4
dev 51800 ± 700 1 ± 0 2.1e-05 ± 9e-06 29.3 ± 0.5
Full metrics [sampling interval: 10]

Full metrics [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 51000 ± 2000 1 ± 0 1.6e-05 ± 7e-06 30 ± 1
3.5.0 51000 ± 1000 1 ± 0 2.8e-05 ± 1e-05 30.0 ± 0.8
dev 51000 ± 1000 1 ± 0 1.6e-05 ± 7e-06 29.9 ± 1.0
Full metrics [sampling interval: 100]

Full metrics [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 10000 ± 200 0.002 ± 0.0003 5e-05 ± 3e-05 34.6 ± 0.5
3.5.0 9900 ± 300 0.0025 ± 0.0008 5e-05 ± 3e-05 35.1 ± 1.0
dev 10000 ± 300 0.0021 ± 0.0004 4e-05 ± 4e-05 34.4 ± 0.8
Full metrics [sampling interval: 1000]

Full metrics [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 1840 ± 30 0.0002 ± 0.0003 2e-05 ± 6e-05 39.6 ± 1.0
3.5.0 1850 ± 40 0.0001 ± 0.0002 6e-05 ± 9e-05 40 ± 2
dev 1860 ± 20 0.0004 ± 0.0005 0.0001 ± 0.0002 39 ± 3
Multiprocess wall time [sampling interval: 1]

Multiprocess wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 2600 ± 200 1 ± 0 0.00024 ± 4e-05 250 ± 20
3.5.0 3100 ± 200 1 ± 0 0.00019 ± 6e-05 310 ± 20
dev 3200 ± 200 1 ± 0 0.00014 ± 6e-05 300 ± 20
Multiprocess wall time [sampling interval: 10]

Multiprocess wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 2500 ± 100 1 ± 0 0.00018 ± 5e-05 260 ± 20
3.5.0 3100 ± 100 1 ± 0 0.00018 ± 3e-05 300 ± 10
dev 3100 ± 100 1 ± 0 0.00017 ± 3e-05 310 ± 10
Multiprocess wall time [sampling interval: 100]

Multiprocess wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 2500 ± 200 0.03 ± 0.02 0.0002 ± 0.0003 260 ± 10
3.5.0 3000 ± 200 0.05 ± 0.02 9e-05 ± 3e-05 320 ± 20
dev 3000 ± 200 0.05 ± 0.01 4e-05 ± 5e-05 320 ± 20
Multiprocess wall time [sampling interval: 1000]

Multiprocess wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.4.1 2000 ± 100 0.0009 ± 0.0006 3e-05 ± 2e-05 44 ± 4
3.5.0 2800 ± 200 0.011 ± 0.002 2e-05 ± 2e-05 90 ± 9
dev 2900 ± 100 0.012 ± 0.002 1e-05 ± 2e-05 91 ± 9

@P403n1x87 P403n1x87 marked this pull request as ready for review September 4, 2023 18:11
@P403n1x87 P403n1x87 merged commit b469615 into devel Sep 4, 2023
34 of 38 checks passed
@P403n1x87 P403n1x87 deleted the ci/run-when-necessary branch September 4, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant