Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up support for old versions of Python #239

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

P403n1x87
Copy link
Owner

We remove some old code used for the support of older version of Python that is no longe required.

We remove some old code used for the support of older version of Python
that is no longe required.
@P403n1x87 P403n1x87 self-assigned this Oct 13, 2024
@P403n1x87 P403n1x87 merged commit 741d378 into devel Oct 13, 2024
32 of 40 checks passed
@P403n1x87 P403n1x87 deleted the chore/clean-up-old-code branch October 13, 2024 09:42
Copy link

Austin Benchmarks

Running Austin benchmarks with Python 3.10.15

Benchmark Summary

Comparison of dev against 3.6.0.

The following scenarios show a statistically significant difference in performance between the two versions.

Sample Rate Saturation Error Rate Sampling Speed
Wall time [sampling interval: 10] 🟡 🟢 🟡 🟡
Multiprocess wall time [sampling interval: 1] 🟡 🟡 🔴 🟡

Benchmark Results

Wall time [sampling interval: 1]

Wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 103000 ± 3000 1 ± 0 2e-05 ± 1e-05 15.1 ± 0.7
dev 104000 ± 2000 1 ± 0 1.4e-05 ± 7e-06 14.8 ± 0.6
Wall time [sampling interval: 10]

Wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 97000 ± 6000 0.91 ± 0.02 2e-05 ± 1e-05 15.4 ± 0.5
dev 98000 ± 4000 0.85 ± 0.01 1.8e-05 ± 8e-06 15.1 ± 0.3
Wall time [sampling interval: 100]

Wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12300 ± 200 0.0007 ± 0.0002 5e-05 ± 5e-05 16.8 ± 0.8
dev 12300 ± 200 0.0008 ± 0.0002 6e-05 ± 6e-05 16.3 ± 0.7
Wall time [sampling interval: 1000]

Wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1860 ± 30 0 ± 0 3e-05 ± 0.0001 17.4 ± 0.8
dev 1860 ± 30 0.0001 ± 0.0002 3e-05 ± 0.0001 18.2 ± 0.9
CPU time [sampling interval: 1]

CPU time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 30000 ± 1000 1 ± 0 7e-05 ± 3e-05 26.7 ± 0.8
dev 31000 ± 1000 1 ± 0 8e-05 ± 2e-05 26.1 ± 0.6
CPU time [sampling interval: 10]

CPU time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 31000 ± 1000 1 ± 0 6e-05 ± 5e-05 26.3 ± 0.9
dev 31000 ± 1000 1 ± 0 6e-05 ± 3e-05 26.1 ± 0.9
CPU time [sampling interval: 100]

CPU time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6300 ± 10 0.003 ± 0.001 0.0001 ± 0.0001 31.0 ± 0.8
dev 6290 ± 9 0.003 ± 0.001 0.0001 ± 0.0001 30.8 ± 0.9
CPU time [sampling interval: 1000]

CPU time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 947 ± 2 0 ± 0 0.0002 ± 0.0003 33 ± 2
dev 947 ± 2 0 ± 0 0.0001 ± 0.0003 33 ± 2
RSA keygen [sampling interval: 1]

RSA keygen [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 32000 ± 1000 1 ± 0 0.0005 ± 0.0005 31 ± 1
dev 31000 ± 2000 1 ± 0 0.0005 ± 0.0002 31 ± 2
RSA keygen [sampling interval: 10]

RSA keygen [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 31000 ± 2000 1 ± 0 0.0005 ± 0.0004 32 ± 3
dev 32000 ± 1000 1 ± 0 0.0006 ± 0.0005 31 ± 1
RSA keygen [sampling interval: 100]

RSA keygen [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6290 ± 30 0.02 ± 0.03 0.003 ± 0.003 38 ± 5
dev 6290 ± 20 0.02 ± 0.02 0.002 ± 0.001 37 ± 3
RSA keygen [sampling interval: 1000]

RSA keygen [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 943 ± 1 0 ± 0 0.001 ± 0.002 38 ± 6
dev 942 ± 2 0 ± 0 0.001 ± 0.003 39 ± 8
Full metrics [sampling interval: 1]

Full metrics [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 38000 ± 1000 1 ± 0 5e-05 ± 3e-05 39 ± 1
dev 38900 ± 800 1 ± 0 5e-05 ± 1e-05 39 ± 1
Full metrics [sampling interval: 10]

Full metrics [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 39000 ± 700 1 ± 0 5e-05 ± 3e-05 39.0 ± 0.5
dev 38800 ± 800 1 ± 0 6e-05 ± 2e-05 38.6 ± 0.8
Full metrics [sampling interval: 100]

Full metrics [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12300 ± 300 0.0046 ± 0.0009 7e-05 ± 7e-05 44 ± 1
dev 12200 ± 200 0.0055 ± 0.0009 0.00014 ± 7e-05 44 ± 1
Full metrics [sampling interval: 1000]

Full metrics [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1850 ± 30 0.0 ± 0.0001 0.0002 ± 0.0002 47 ± 2
dev 1850 ± 30 0 ± 0 0.0002 ± 0.0002 47 ± 1
Multiprocess wall time [sampling interval: 1]

Multiprocess wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 3900 ± 500 1 ± 0 0.0002 ± 0.0001 220 ± 20
dev 4200 ± 200 1 ± 0 0.00032 ± 9e-05 230 ± 10
Multiprocess wall time [sampling interval: 10]

Multiprocess wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 4130 ± 100 1 ± 0 0.00031 ± 9e-05 231 ± 5
dev 4200 ± 200 1 ± 0 0.00031 ± 9e-05 230 ± 10
Multiprocess wall time [sampling interval: 100]

Multiprocess wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 3600 ± 600 0.034 ± 0.005 0.0002 ± 0.0001 230 ± 20
dev 4100 ± 200 0.034 ± 0.005 0.00018 ± 7e-05 230 ± 10
Multiprocess wall time [sampling interval: 1000]

Multiprocess wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 3600 ± 500 0.01 ± 0.005 5e-05 ± 3e-05 120 ± 30
dev 3860 ± 100 0.006 ± 0.001 5e-05 ± 4e-05 90 ± 8

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (7c42586) to head (af9ba26).
Report is 2 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #239      +/-   ##
==========================================
- Coverage   69.09%   68.73%   -0.37%     
==========================================
  Files          27       27              
  Lines        2521     2517       -4     
  Branches      771      770       -1     
==========================================
- Hits         1742     1730      -12     
- Misses        447      455       +8     
  Partials      332      332              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant