Code review

Code review suggestions. Signed-off-by: Ivan Hrasko <[email protected]>
PANTHEONtech · May 21, 2024 · 5877d8a · 5877d8a
1 parent f505c59
commit 5877d8a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/lighty-core/lighty-codecs-util/src/main/java/io/lighty/codecs/util/ConverterUtils.java b/lighty-core/lighty-codecs-util/src/main/java/io/lighty/codecs/util/ConverterUtils.java
@@ -90,14 +90,15 @@ public static Optional<? extends NotificationDefinition> loadNotification(
      * @return {@link QName} for input data or empty.
      */
     public static Optional<QName> getRpcQName(final XmlElement xmlElement) {
-        String namespace = xmlElement.namespace();
+        String nxmlNamespace = xmlElement.namespace();
         String name = xmlElement.getName();
         if (Strings.isNullOrEmpty(name)) {
             return Optional.empty();
         }
         String revision = null;
-        if (namespace != null) {
-            String[] split = namespace.split("\\?");
+        String namespace;
+        if (nxmlNamespace != null) {
+            String[] split = nxmlNamespace.split("\\?");
             if (split.length > 1 && split[1].contains("revision=")) {
                 revision = split[1].replace("revision=", "");
 

diff --git a/lighty-modules/lighty-bgp/src/main/java/io/lighty/modules/bgp/deployer/BgpModule.java b/lighty-modules/lighty-bgp/src/main/java/io/lighty/modules/bgp/deployer/BgpModule.java
@@ -151,7 +151,7 @@ protected boolean stopProcedure() {
         try {
             bgpNettyGroups.close();
         } catch (Exception e) {
-            LOG.warn("Failed to stop BGP dispatcher", e);
+            LOG.warn("Failed to stop BGP Netty groups", e);
             closeSuccess = false;
         }
         try {

diff --git a/...onf-sb/src/main/java/io/lighty/modules/southbound/netconf/impl/NetconfTopologyPlugin.java b/...onf-sb/src/main/java/io/lighty/modules/southbound/netconf/impl/NetconfTopologyPlugin.java
@@ -55,10 +55,8 @@ protected boolean initProcedure() {
                 lightyServices.getBindingDataBroker(), lightyServices.getRpcProviderService(),
                 lightyServices.getClusterSingletonServiceProvider(), encryptionService);
         final NetconfClientFactory netconfFactory = new NetconfClientFactoryImpl(new DefaultNetconfTimer());
-        final CredentialProvider credentialProvider
-            = new DefaultCredentialProvider(service);
-        final SslContextFactoryProvider factoryProvider
-            = new DefaultSslContextFactoryProvider(service);
+        final CredentialProvider credentialProvider = new DefaultCredentialProvider(service);
+        final SslContextFactoryProvider factoryProvider = new DefaultSslContextFactoryProvider(service);
         final NetconfClientConfigurationBuilderFactory factory = new NetconfClientConfigurationBuilderFactoryImpl(
             encryptionService, credentialProvider, factoryProvider);
         final NetconfTopologySchemaAssembler assembler = new NetconfTopologySchemaAssembler(1,1,10, TimeUnit.SECONDS);