Improve calcium #1862
Closed
Improve calcium #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addCallback methods do not need to be implemented since they are default. Also change the future method to return completed future since it's not chained. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
Just use .namespace() to return namespace, and if namespace is null, just use name. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
No need to import these classes when ImmutableNodes can be used for same purpose. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
This service is no longer required as a part of this rework: opendaylight/controller@9917911 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
Use these changes to modernize RPC implementation registration: opendaylight/lispflowmapping@27c0004 JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
There is no need to bind it again, since it is already bound from DOMSchemaService. JIRA: LIGHTY-298 Signed-off-by: tobias.pobocik <[email protected]>
Code review suggestions. Signed-off-by: Ivan Hrasko <[email protected]>
|
Superseded by #1860. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.