-
Notifications
You must be signed in to change notification settings - Fork 0
XP 추가 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pdh0128
wants to merge
7
commits into
dev-0.2
Choose a base branch
from
feature-0.2.8/xp/PW-428
base: dev-0.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
XP 추가 #37
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2a1e794
Merge pull request #35 from PARADOX-BSSM/dev-0.2
yuuki08noah fdf57a4
Format application.yml for better readability
yuuki08noah 94b58d0
fix :: application.yml
yuuki08noah 7ea9eac
fix :: application.yml
yuuki08noah d3035d5
Change CI workflow to use release.yml
yuuki08noah fa29f10
feat :: memorial apply avro schema 정의
pdh0128 1c7d2c8
feat :: memorial apply request
pdh0128 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "type": "record", | ||
| "name": "MemorialAppliedAvroSchema", | ||
| "namespace": "windeath44.server.application.avro", | ||
| "doc": "Event emitted when a user submits a memorial application.", | ||
| "fields": [ | ||
| {"name": "memorialApplicationId", "type": "long", "doc": "Unique identifier for the memorial application"}, | ||
| {"name": "applicantId", "type": "string", "doc": "User submitting the application"}, | ||
| {"name": "characterId", "type": "long", "doc": "Character the memorial is requested for"}, | ||
| {"name": "content", "type": "string", "doc": "Application content or message"} | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB 저장과 Kafka 발행 간 데이터 일관성 고려 필요
apply()메서드에서 DB 저장 후 Kafka 메시지를 발행합니다. 만약kafkaProducer.send()호출이 실패하면 DB에는 레코드가 저장되지만 이벤트는 발행되지 않아 XP가 누락될 수 있습니다.다음 방안을 고려해 보세요:
🤖 Prompt for AI Agents