TEST to look at Gh build vs tip #7247
Conversation
Added some logging.
Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only.
…s StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation.
|
Please wait (as usual, I cannot tell until when) and don't merge this PR |
…methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :(
Update gh_build
1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus;
|
Yeah I assume we won't merge this PR, I figured it was just the easiest way to look at a diff and see if we could spot anything. |
# Conflicts: # data/pathfinder/paizo/roleplaying_game/core_rulebook/cr_equip_arms_armor.lst
|
Super interesting those tests fail for you but not for me locally! |
|
If you use your version/branch, but not mine, I bet you have this PR: #6975 |
OK, so just a data fix required then? |
…e the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template.
Signed-off-by: Vest <[email protected]>
Added the same task to plugins.gradle Signed-off-by: Vest <[email protected]>
Removed the `buildNsis` task from the Gradle `test_script`, streamlining the build process. Additionally, fixed unnecessary trailing spaces in multiple sections for better formatting consistency. These changes simplify the CI process and improve readability. Signed-off-by: Vest <[email protected]>
This commit deletes `build-gradle.xml` and `pluginbuild.xml` as they are no longer required. The transition to a Gradle-based build system eliminates dependency on Ant, simplifying the build process. Signed-off-by: Vest <[email protected]>
Added a new warning message for remote list preferences in properties. Improved Gradle tasks to include all nested class files for export and bonus plugins, ensuring more comprehensive builds. Signed-off-by: Vest <[email protected]>
…ethod signatures in PCGenTaskExecutor and PluginLoader Signed-off-by: Vest <[email protected]>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <[email protected]>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…lows Signed-off-by: Vest <[email protected]>
# Conflicts: # build.gradle
…n in wrapper scripts Signed-off-by: Vest <[email protected]>
… with new tests Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…test classes Signed-off-by: Vest <[email protected]>
|
Where do we stand with this? |
|
I am updating this PR from time to time. But I am stuck at failed tests (sometimes your changes break the tests that were green before), and I am analyzing the results (but not that fast as I wanted), and I am still not certain that all three OSes are 100% working :( |
…sponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372) Signed-off-by: Vest <[email protected]>
# Conflicts: # build.gradle
Gradle wrapper to 9.1.0 Signed-off-by: Vest <[email protected]>
# Conflicts: # code/src/java/pcgen/core/PlayerCharacter.java # code/src/java/pcgen/io/ExportHandler.java
…ations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10. Signed-off-by: Vest <[email protected]>
…radle Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
…lity class Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
Signed-off-by: Vest <[email protected]>
4 participants
No description provided.