Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two small issues with substitution nulls #501

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

NWilson
Copy link
Contributor

@NWilson NWilson commented Sep 27, 2024

  • pcre2_substitute() is not following the documentation's recommended practice for handling MARK names with embedded NULs.
  • The CRLF-handling code assumes that, if newline_convention is not CR or LF, then CRLF is a valid newline. Presumably, this was true once upon a time, but now PCRE2_NEWLINE_NUL has been added. Corrected this minuscule error.

@PhilipHazel PhilipHazel merged commit 311eef6 into PCRE2Project:master Sep 27, 2024
14 checks passed
@NWilson NWilson deleted the user/niwilson/subst-nulls branch September 30, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants