Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for negated /[^\P{Lu}]/i behaviour #550

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

NWilson
Copy link
Contributor

@NWilson NWilson commented Nov 6, 2024

PCRE2's behaviour matches Perl currently, and Python's regex module (the standard re module doesn't have \P{...}).

However, JavaScript behaviour changed recently (when they added the new 'v' flag; the old 'u' flag's behaviour is unchanged), so this case is worth additional testing.

Raised in issue #497.

PCRE2's behaviour matches Perl currently, and Python's regex module
(the standard re module doesn't have \P{...}).

However, JavaScript behaviour changed recently (when they added the new
'v' flag; the old 'u' flag's behaviour is unchanged), so this case is
worth additional testing.

Raised in issue PCRE2Project#497.
Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 62b3cec into PCRE2Project:master Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants