Rust code #91
Merged
Rust code #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
approved these changes
Dec 4, 2024
dev_steps.md
Outdated
|
|
||
| 4. Build the project in editable mode | ||
| ```sh | ||
| make build |
There was a problem hiding this comment.
Failed for me with:
INFO: pip is looking at multiple versions of quantum-pecos[simulators] to determine which version is compatible with other requirements. This could take a while.
ERROR: Could not find a version that satisfies the requirement pyquest>=0.0.1; extra == "simulators" (from quantum-pecos[simulators]) (from versions: none)
ERROR: No matching distribution found for pyquest>=0.0.1; extra == "simulators"
I believe this was because I was on Python 3.13 at the time. Worked after switching to 3.12. Perhaps pyproject.toml should exclude 3.13 if it's not supported.
There was a problem hiding this comment.
Hmmm, pyquest isn't a necessary component. Sounds like maybe I need to adjust make build or the pyproject.toml and re-evaluate 3.13.
Good catch. Thanks!
qartik
reviewed
Dec 7, 2024
qartik
reviewed
Dec 7, 2024
Co-authored-by: Kartik Singhal <[email protected]>
Co-authored-by: Kartik Singhal <[email protected]>
…default state-vector sim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplication of PR #77 (and essentially PR #53) due to git repo cleanup shenanigans.
This introduces a Rust version of some of the code, focused on the stabilizer simulator, and should hopefully fixed most of the issues mentioned in the reviews of PR #77.
The main concerns are the makefile, state of the Rust code, and general structure of the monolithic project.