order by popcon as classmethod, and tests

Signed-off-by: Lucas Severo <[email protected]>
Signed-off-by: Lucas Mattioli <[email protected]>

pet/classifier.py

@@ -175,7 +175,8 @@ def __init__(self, session, named_trees,
                 nt, bugs.get(nt.source, []), suite_packages.get(nt.source, []),
                 tags.get(nt.package_id, [])))
 
-    def order_packages_by_popcon(self, packages):
+    @classmethod
+    def order_packages_by_popcon(cls, packages):
         has_no_popcon = []
         packages_queue = PriorityQueue()
         for package in packages:
@@ -198,7 +199,7 @@ def order_packages_by_popcon(self, packages):
         return ordered_packages
 
     def classify(self):
-        self.packages = self.order_packages_by_popcon(self.packages)
+        self.packages = Classifier.order_packages_by_popcon(self.packages)
         classified = dict()
         for package in self.packages:
             if package.ready_for_upload:

test/test_classifier.py

@@ -1,11 +1,33 @@
 import unittest
 import pet.classifier
+from pet.classifier import Classifier
+import random
+import popcon
+
+
+class FakePackage():
+    def __init__(self):
+        self.name = ''
 
 
 class TestPetClassifier(unittest.TestCase):
 
     def setUp(self):
         pass
 
-    def test_something(self):
-        pass
+    def test_classify_popcon(self):
+
+        package_libdigest_md4_perl = FakePackage()
+        package_libdigest_md4_perl.name = 'libdigest-md4-perl'
+        package_libsharyanto_utils_perl = FakePackage()
+        package_libsharyanto_utils_perl.name = 'libsharyanto-utils-perl'
+
+        packages = [package_libdigest_md4_perl, package_libsharyanto_utils_perl]
+        random.shuffle(packages)
+        ordered_packages = Classifier.order_packages_by_popcon(packages)
+
+        for i in range(0, len(packages) - 1):
+            package1 = popcon.package(ordered_packages[i].name)
+            package2 = popcon.package(ordered_packages[i + 1].name)
+            self.assertGreaterEqual(package1[ordered_packages[i].name],
+                                    package2[ordered_packages[i + 1].name])