Revert "Update dependencies and use non-deprecated methods" #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d16cf73.
cswhite2000
approved these changes
Aug 23, 2023
|
Electroid/SportPaper#136 should resolve this on SportPaper's end. There are implications for plugins which depend on PGM and Adventure, and want to support Spigot unfortunately. However, Community itself does require SportPaper to my knowledge. It seems difficult to reconcile this if we want to use up to date libraries. |
Electroid
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1212
Updated adventure makes use of JsonObject.size(), which doesn't exist unstil gson 2.7 while sportpaper uses 2.2. This breaks certain types of text serialization, and, in particular, breaks community's cross-server adminchat.