Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'ischemic stroke' to proper trait categories #360

Merged

Conversation

fyvon
Copy link
Member

@fyvon fyvon commented Apr 26, 2024

HP_0002140 Ischemic stroke was categorised as 'Others' whereas it should be 'cardiovascular disease' and 'neurological disorder' as it is the case for EFO_0000712 Stroke.

For that it is necessary to add the parent terms Abnormality of the cardiovascular system to "Cardiovascular disease" and Abnormality of the nervous system to "Neurological disorder".

"Abnormality of the cardiovascular system" is labeled as synonym of "Cardiovascular disease", whereas "Abnormality of the nervous system" is not labeled as synonym of "nervous system disease"

@fyvon fyvon added the data issue Issue with data label Apr 26, 2024
@fyvon fyvon requested review from smlmbrt and ens-lgil April 26, 2024 18:28
@fyvon fyvon merged commit b8201b1 into PGScatalog:master May 7, 2024
1 check passed
@fyvon fyvon deleted the data/efotrait_category_ischemic_stroke branch May 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data issue Issue with data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants